{"id":175,"date":"2010-08-08T14:05:31","date_gmt":"2010-08-08T18:05:31","guid":{"rendered":"http:\/\/littlesvr.ca\/masters\/?p=175"},"modified":"2010-08-08T14:05:31","modified_gmt":"2010-08-08T18:05:31","slug":"unexperienced-reviewers","status":"publish","type":"post","link":"http:\/\/littlesvr.ca\/masters\/2010\/08\/08\/unexperienced-reviewers\/","title":{"rendered":"Unexperienced reviewers"},"content":{"rendered":"<p>Again I should say a big thanks to <a href=\"http:\/\/zuzelvp47uoft.wordpress.com\/\">Zuzel Vera Pacheco<\/a>, <a href=\"http:\/\/mikeconley.ca\/blog\/\">Mike Conley<\/a>, and <a href=\"http:\/\/ajfowler.wordpress.com\/\">Alecia Fowler<\/a> for helping me iron out potential problems with my experiment.<\/p>\n<p>A final lesson I learned this week from the test runs with my fellows is that I should have considered that unexperienced reviewers will not actually know how to do a code review, so I have to account for that.<\/p>\n<p>I think the best way to deal with that problem is to have a checklist of the types of comments the participants could give, including:<\/p>\n<ul>\n<li>Poor or very good coding style in any way (whitespace, variable\/function\/class names, etc)<\/li>\n<li>Functional mistakes (doesn&#8217;t do what it should as far as the reviewer can tell)<\/li>\n<li>Poor or very good design in any way (classes, class members, data structures, etc.)<\/li>\n<li>Poor or very good comments<\/li>\n<li>Poor or very good error handling<\/li>\n<li>Poor or very good performance<\/li>\n<\/ul>\n<p>Perhaps I will even require that the participants only give feedback from these categories, though I don&#8217;t like that idea because I don&#8217;t want to exclude something really important by mistake.<\/p>\n<div id=\"_mcePaste\" style=\"position: absolute; left: -10000px; top: 0px; width: 1px; height: 1px; overflow: hidden;\"><a href=\"http:\/\/zuzelvp47uoft.wordpress.com\/\"> Zuzel Vera Pacheco<\/a><\/div>\n","protected":false},"excerpt":{"rendered":"<p>Again I should say a big thanks to Zuzel Vera Pacheco, Mike Conley, and Alecia Fowler for helping me iron out potential problems with my experiment. A final lesson I learned this week from the test runs with my fellows is that I should have considered that unexperienced reviewers will not actually know how to [&hellip;]<\/p>\n","protected":false},"author":2,"featured_media":0,"comment_status":"open","ping_status":"closed","sticky":false,"template":"","format":"standard","meta":{"footnotes":""},"categories":[1],"tags":[],"_links":{"self":[{"href":"http:\/\/littlesvr.ca\/masters\/wp-json\/wp\/v2\/posts\/175"}],"collection":[{"href":"http:\/\/littlesvr.ca\/masters\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"http:\/\/littlesvr.ca\/masters\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"http:\/\/littlesvr.ca\/masters\/wp-json\/wp\/v2\/users\/2"}],"replies":[{"embeddable":true,"href":"http:\/\/littlesvr.ca\/masters\/wp-json\/wp\/v2\/comments?post=175"}],"version-history":[{"count":2,"href":"http:\/\/littlesvr.ca\/masters\/wp-json\/wp\/v2\/posts\/175\/revisions"}],"predecessor-version":[{"id":177,"href":"http:\/\/littlesvr.ca\/masters\/wp-json\/wp\/v2\/posts\/175\/revisions\/177"}],"wp:attachment":[{"href":"http:\/\/littlesvr.ca\/masters\/wp-json\/wp\/v2\/media?parent=175"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"http:\/\/littlesvr.ca\/masters\/wp-json\/wp\/v2\/categories?post=175"},{"taxonomy":"post_tag","embeddable":true,"href":"http:\/\/littlesvr.ca\/masters\/wp-json\/wp\/v2\/tags?post=175"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}